fix: unify background color for No more data indicator #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Color.itemBg background to LoadmoreIndicatorView to match content area - Add Color.itemBg background to ScrollView in UpdatableView for consistent background color throughout the entire scrollable area 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Copilot finished reviewing on behalf of
graycreate
December 1, 2025 15:08
There was a problem hiding this comment.
Pull request overview
This PR fixes a visual inconsistency where the "No more data" indicator and the area below it displayed a black background instead of matching the lighter Color.itemBg used in the post content area.
- Adds
Color.itemBgbackground to theScrollViewinUpdatableViewfor consistent background throughout the scrollable area - Adds
Color.itemBgbackground and.greedyWidth()modifier toLoadmoreIndicatorViewto match the post content styling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
V2er/View/Widget/Updatable/UpdatableView.swift |
Adds .background(Color.itemBg) to the ScrollView to ensure consistent background color throughout the entire scrollable area |
V2er/View/Widget/Updatable/LoadmoreIndicatorView.swift |
Adds .greedyWidth() and .background(Color.itemBg) to ensure the "No more data" indicator spans the full width with consistent background color |
Code Coverage Report ❌Current coverage: 27.89% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Color.itemBgbackground toLoadmoreIndicatorViewto match the post content areaColor.itemBgbackground toScrollViewinUpdatableViewfor consistent background color throughout the entire scrollable areaThis fixes the visual inconsistency where the "No more data" section and the area below it showed a pure black background instead of matching the lighter post content background color.
Test plan
🤖 Generated with Claude Code